Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit tests, refactor, new slideshow feature, other improvements #55

Merged
merged 29 commits into from
Aug 6, 2014

Commits on Jan 7, 2014

  1. .gitignore updated

    Eclipse metadata, Emacs *~ and .pyc are now ignored.
    leguye committed Jan 7, 2014
    Configuration menu
    Copy the full SHA
    f923c39 View commit details
    Browse the repository at this point in the history
  2. unit tests: new test.py, using unittest python lib

    Tested functions:
    	* findStaffLinesInImage()
    Tested classes:
    	* VideoFrameWriter:
    		- image handling methods:
    			. isLineBlank()
            		. getTopAndBottomMarginSizes()
    			. getCropTopAndBottom()
    			. cropFrame()
    		- time handling methods:
    			. ticksToSecs()
    			. secsElapsedForTempoChanges()
    leguye committed Jan 7, 2014
    Configuration menu
    Copy the full SHA
    c65a8cc View commit details
    Browse the repository at this point in the history
  3. refactor: add 'utils' module for some utility functions

    To maintain the code more easily, the program will be split into several modules.
    setDebug() and setRunDir() functions are handling global var DEBUG and runDir.
    leguye committed Jan 7, 2014
    Configuration menu
    Copy the full SHA
    b339675 View commit details
    Browse the repository at this point in the history
  4. refactor: add 'video' module

    Move VideoFrameWriter and some image scanning functions into a new 'video' module.
    Update unit tests.
    leguye committed Jan 7, 2014
    Configuration menu
    Copy the full SHA
    bff350b View commit details
    Browse the repository at this point in the history
  5. add initialisation of index variable in getNoteIndices()

    Avoid an 'undefined var' at execution?
    leguye committed Jan 7, 2014
    Configuration menu
    Copy the full SHA
    faf9b49 View commit details
    Browse the repository at this point in the history
  6. update authors

    leguye committed Jan 7, 2014
    Configuration menu
    Copy the full SHA
    713eda4 View commit details
    Browse the repository at this point in the history
  7. refactor: new 'ScoreImage' class managing score image cropping and tr…

    …avelling
    
    Some VideoFrameWriter methods are now moved to this class.
    The getCropTopAndBottomMarginSizes() method is replaced by the topCroppable() and
    bottomCroppable() methods which respectivly return the number of pixels the image can
    be cropped on top an bottom.
    An instance is now used by VideoFrameWriter.
    
    Some unused code has been removed in VideoFrameWriter (write and secsElapsedForTempoChanges)
    leguye committed Jan 7, 2014
    Configuration menu
    Copy the full SHA
    5fda08a View commit details
    Browse the repository at this point in the history
  8. unit tests: 'ScoreImage' testing

    Update the tests for the new class ScoreImage.
    The tests of image handling methods are moved to the ScoreImageTest test class.
    
    Tested functions:
    	* findStaffLinesInImage()
    Tested classes:
        	* VideoFrameWriter:
        		. ticksToSecs()
        		. secsElapsedForTempoChanges()
    	* ScoreImage
        		. __isLineBlank()
        		. __setCropTopAndBottom()
        		. __cropFrame()
    		. topCroppable()
    		. bottomCroppable()
    		. makeFrame()
    leguye committed Jan 7, 2014
    Configuration menu
    Copy the full SHA
    fdfe0ab View commit details
    Browse the repository at this point in the history
  9. The loop on frame generation is now based on midi ticks

    ...instead of image notes indexes.
    Less dependant from the scoreImage class.
    leguye committed Jan 7, 2014
    Configuration menu
    Copy the full SHA
    17a84a6 View commit details
    Browse the repository at this point in the history
  10. add VideoFrameWriter.scoreImage property

    The ScoreImage instance of VideoFrameWriter can now be set as a public property.
    Some parameters of the VideoFrameWriter constructor are removed and the
    write() method has now no parameter. These parameters are attached to
    the ScoreImage instance.
    leguye committed Jan 7, 2014
    Configuration menu
    Copy the full SHA
    99f4aeb View commit details
    Browse the repository at this point in the history

Commits on Jan 8, 2014

  1. add --measure-cursor option, following score measure by measure

    Implements a measure cursor that is slightly less intrusive than the line
    cursor following each note.
    Updates writeSpaceTimeDumper() function the measures bars positions.
    New function getMeasuresIndices().
    leguye committed Jan 8, 2014
    Configuration menu
    Copy the full SHA
    698727b View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    0a60a03 View commit details
    Browse the repository at this point in the history
  3. add --note-cursor and --no-cursor options

    These options are added to be more coherent with --measure-cursor, and to allow no cursor at all.
    magiraud committed Jan 8, 2014
    Configuration menu
    Copy the full SHA
    5cdffd8 View commit details
    Browse the repository at this point in the history

Commits on Jan 9, 2014

  1. add --slide-show option, displaying fixed pictures in one area of the…

    … video
    
    VideoFrameWriter is now able to push up medias.
    leguye committed Jan 9, 2014
    Configuration menu
    Copy the full SHA
    b575fc2 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    e778c2a View commit details
    Browse the repository at this point in the history
  3. --slide-show: add a cursor line at a constant speed

    This cursor can be used when the slide show displays some structure diagram.
    Some hard coded values should be set by command line options...
    leguye committed Jan 9, 2014
    Configuration menu
    Copy the full SHA
    1667ef5 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    64df6b4 View commit details
    Browse the repository at this point in the history

Commits on Jan 14, 2014

  1. adds height and width in ScoreImage constructor

    Deletes height and width in VideoFrameWriter constructor
    (No height limit, score)
    leguye committed Jan 14, 2014
    Configuration menu
    Copy the full SHA
    9eeabbc View commit details
    Browse the repository at this point in the history
  2. unit tests: 'VideoFrameWriter' testing

    Tested classes:
    	* VideoFrameWriter:
        		. push()
        		. scoreImageSetter()
    leguye committed Jan 14, 2014
    Configuration menu
    Copy the full SHA
    7c53874 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    06d6b12 View commit details
    Browse the repository at this point in the history

Commits on Feb 4, 2014

  1. refactor: new 'synchro.TimeCode' class to drive medias

    Time handling methods are moved to this class.
    The design pattern 'Observer' is used.
    New 'synchro' module.
    leguye committed Feb 4, 2014
    Configuration menu
    Copy the full SHA
    b484b81 View commit details
    Browse the repository at this point in the history
  2. unit tests: 'TimeCode' class testing

    Add tests for the new class TimeCode, update some tests.
    Some new fonctional tests (testCompleteFollowing)
    
    Tested classes:
    	* TimeCode:
    		. ticksToSecs()
    		. secsElapsedForTempoChanges()
    		. nbFramesToNextNote()
    		. goToNextNote()
    		. atEnd()
    	* ScoreImage:
    		. currentXposition
    		. moveToNextNote()
    		. cropFrame()
    leguye committed Feb 4, 2014
    Configuration menu
    Copy the full SHA
    8a9880f View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    9e22d49 View commit details
    Browse the repository at this point in the history

Commits on Mar 3, 2014

  1. Configuration menu
    Copy the full SHA
    cdcc954 View commit details
    Browse the repository at this point in the history

Commits on Mar 11, 2014

  1. Configuration menu
    Copy the full SHA
    937e3f0 View commit details
    Browse the repository at this point in the history
  2. ly2video.py: use argparse to parse command-line

    As of Python 2.7, optparse is deprecated in favour of argparse.
    magiraud committed Mar 11, 2014
    Configuration menu
    Copy the full SHA
    5850f9b View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    b2206c0 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    8833d0e View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    23033cd View commit details
    Browse the repository at this point in the history