Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed types #137

Merged
merged 5 commits into from
Dec 28, 2024
Merged

Fixed types #137

merged 5 commits into from
Dec 28, 2024

Conversation

davidbrochart
Copy link
Contributor

@davidbrochart davidbrochart commented Dec 28, 2024

Changes

Fixes #134.

Checklist

If this is a user-facing code change, like a bugfix or a new feature, please ensure that
you've fulfilled the following conditions (where applicable):

  • You've added tests (in tests/) added which would fail without your patch
  • You've updated the documentation (in docs/, in case of behavior changes or new
    features)
  • You've added a new changelog entry (in docs/versionhistory.rst).

If this is a trivial change, like a typo fix or a code reformatting, then you can ignore
these instructions.

Updating the changelog

If there are no entries after the last release, use **UNRELEASED** as the version.
If, say, your patch fixes issue #123, the entry should look like this:

- Fix big bad boo-boo in task groups
  (`#123 <https://github.com/asphalt-framework/asphalt/issues/123>`_; PR by @yourgithubaccount)

If there's no issue linked, just link to your pull request instead by updating the
changelog after you've created the PR.

@coveralls
Copy link

coveralls commented Dec 28, 2024

Coverage Status

coverage: 97.527%. remained the same
when pulling 80f6e6e on davidbrochart:fix-types
into c7f994a on asphalt-framework:5.0.

@agronholm
Copy link
Member

Two issues I'd like to point out:

  1. There is no accompanying regression test
  2. How much sense does the is_class() test make after this change? Wouldn't it be better to treat the case of a Sequence as special, and default to assuming that types is a class?

tests/test_component.py Outdated Show resolved Hide resolved
@agronholm agronholm merged commit 0c6cc96 into asphalt-framework:5.0 Dec 28, 2024
14 checks passed
@davidbrochart davidbrochart deleted the fix-types branch December 28, 2024 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants