comment and doc

askwang · Oct 14, 2024 · f8e7af4 · f8e7af4
1 parent aeb0f6a
commit f8e7af4
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 5 deletions.
diff --git a/docs/content/spark/sql-ddl.md b/docs/content/spark/sql-ddl.md
@@ -209,3 +209,9 @@ CREATE TABLE my_table_all (
 );
 CREATE TABLE my_table_all_as PARTITIONED BY (dt) TBLPROPERTIES ('primary-key' = 'dt,hh') AS SELECT * FROM my_table_all;
 ```
+
+## Show Tags
+The SHOW TAGS statement is used to list all tags of a table.
+```
+SHOW TAGS my_table;
+```
diff --git a/...paimon-spark-common/src/main/scala/org/apache/paimon/spark/execution/PaimonStrategy.scala b/...paimon-spark-common/src/main/scala/org/apache/paimon/spark/execution/PaimonStrategy.scala
@@ -25,7 +25,7 @@ import org.apache.spark.sql.{SparkSession, Strategy}
 import org.apache.spark.sql.catalyst.InternalRow
 import org.apache.spark.sql.catalyst.expressions.{Expression, GenericInternalRow, PredicateHelper}
 import org.apache.spark.sql.catalyst.plans.logical.{CreateTableAsSelect, LogicalPlan}
-import org.apache.spark.sql.connector.catalog.{CatalogManager, Identifier, PaimonLookupCatalog, TableCatalog}
+import org.apache.spark.sql.connector.catalog.{Identifier, PaimonLookupCatalog, TableCatalog}
 import org.apache.spark.sql.execution.SparkPlan
 import org.apache.spark.sql.execution.shim.PaimonCreateTableAsSelectStrategy
 
@@ -46,6 +46,7 @@ case class PaimonStrategy(spark: SparkSession)
     case c @ PaimonCallCommand(procedure, args) =>
       val input = buildInternalRow(args)
       PaimonCallExec(c.output, procedure, input) :: Nil
+
     case t @ ShowTagsCommand(PaimonCatalogAndIdentifier(catalog, ident)) =>
       ShowTagsExec(catalog, ident, t.output) :: Nil
     case _ => Nil
@@ -61,11 +62,11 @@ case class PaimonStrategy(spark: SparkSession)
 
   private object PaimonCatalogAndIdentifier {
     def unapply(identifier: Seq[String]): Option[(TableCatalog, Identifier)] = {
-      val catalogAndIdentifer =
+      val catalogAndIdentifier =
         SparkUtils.catalogAndIdentifier(spark, identifier.asJava, catalogManager.currentCatalog)
-      catalogAndIdentifer.catalog match {
+      catalogAndIdentifier.catalog match {
         case paimonCatalog: SparkCatalog =>
-          Some((paimonCatalog, catalogAndIdentifer.identifier()))
+          Some((paimonCatalog, catalogAndIdentifier.identifier()))
         case _ =>
           None
       }

diff --git a/...k/paimon-spark-common/src/main/scala/org/apache/paimon/spark/execution/ShowTagsExec.scala b/...k/paimon-spark-common/src/main/scala/org/apache/paimon/spark/execution/ShowTagsExec.scala
@@ -42,7 +42,8 @@ case class ShowTagsExec(catalog: TableCatalog, ident: Identifier, out: Seq[Attri
         val tagNames = paimonTable.tagManager().allTagNames()
         tags = tagNames.asScala.toList.sorted.map(t => InternalRow(UTF8String.fromString(t)))
       case t =>
-        throw new UnsupportedOperationException(s"Can not show tags for non-paimon table: $t")
+        throw new UnsupportedOperationException(
+          s"Can not show tags for non-paimon FileStoreTable: $t")
     }
     tags
   }