1

askwang · Oct 9, 2024 · 8cec8c1 · 8cec8c1
1 parent b2641ad
commit 8cec8c1
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 1 deletion.
diff --git a/paimon-core/src/main/java/org/apache/paimon/utils/TagManager.java b/paimon-core/src/main/java/org/apache/paimon/utils/TagManager.java
@@ -188,7 +188,10 @@ public void deleteTag(
             List<TagCallback> callbacks) {
         checkArgument(
                 !StringUtils.isNullOrWhitespaceOnly(tagName), "Tag name '%s' is blank.", tagName);
-        checkArgument(tagExists(tagName), "Tag '%s' doesn't exist.", tagName);
+        if (!tagExists(tagName)) {
+            LOG.warn("Tag '{}' doesn't exist.", tagName);
+            return;
+        }
 
         Snapshot taggedSnapshot = taggedSnapshot(tagName);
         List<Snapshot> taggedSnapshots;

diff --git a/...on/src/test/scala/org/apache/paimon/spark/procedure/CreateAndDeleteTagProcedureTest.scala b/...on/src/test/scala/org/apache/paimon/spark/procedure/CreateAndDeleteTagProcedureTest.scala
@@ -191,4 +191,12 @@ class CreateAndDeleteTagProcedureTest extends PaimonSparkTestBase with StreamTes
       }
     }
   }
+
+  test("Paimon Procedure: delete tag not failed if tag not exists") {
+    spark.sql("CREATE TABLE T (id STRING, name STRING) USING PAIMON")
+
+    checkAnswer(
+      spark.sql("CALL paimon.sys.delete_tag(table => 'test.T', tag => 'test_tag')"),
+      Row(true) :: Nil)
+  }
 }