Fix detekt failures and rename tests

.github/workflows/pull-request.yml

@@ -56,9 +56,11 @@ jobs:
         env:
           GOOGLE_SERVICES: ${{ steps.op-secrets.outputs.GOOGLE_SERVICES }}
 
-      - id: gradle
+      - id: gradle-build
         run: ./gradlew build --console=plain
 
+      - run: ./gradlew detektAll --continue --console=plain
+
       - id: screenshot-validation
         run: ./gradlew validateScreenshotTest --console=plain
 
@@ -70,7 +72,7 @@ jobs:
           path: "**/build/reports/screenshotTest/preview/debug"
 
       - uses: thollander/actions-comment-pull-request@v3
-        if: ${{ steps.gradle.outputs.build-scan-url }}
+        if: ${{ steps.gradle-build.outputs.build-scan-url }}
         with:
           message: "Build scan published to ${{ steps.gradle.outputs.build-scan-url }}"
           comment-tag: build-scan-url

conferences-app/src/screenshotTest/kotlin/io/ashdavies/party/events/EventsDetailTest.kt → conferences-app/src/screenshotTest/kotlin/io/ashdavies/party/events/EventsDetailTests.kt

@@ -4,11 +4,11 @@ import androidx.compose.runtime.Composable
 import io.ashdavies.party.tooling.MaterialPreviewTheme
 import io.ashdavies.party.tooling.PreviewDayNight
 
-internal class EventsDetailTest {
+internal class EventsDetailTests {
 
     @Composable
     @PreviewDayNight
-    fun EventsDetailPreview() {
+    private fun EventsDetailPreview() {
         MaterialPreviewTheme {
             EventsDetail(DroidconBerlin)
         }

conferences-app/src/screenshotTest/kotlin/io/ashdavies/party/events/EventsListTest.kt → conferences-app/src/screenshotTest/kotlin/io/ashdavies/party/events/EventsListTests.kt

@@ -11,11 +11,11 @@ import kotlinx.coroutines.flow.flowOf
 
 private val DroidconEvents = listOf(AndroidMakers, DroidconBerlin, DroidconLondon)
 
-internal class EventsListTest {
+internal class EventsListTests {
 
     @Composable
     @PreviewDayNight
-    fun EventsListPreview(data: List<Event> = DroidconEvents) {
+    private fun EventsListPreview(data: List<Event> = DroidconEvents) {
         MaterialPreviewTheme {
             EventsList(
                 state = EventsScreen.State(lazyPagingItems(flowOf(PagingData.from(data)))),

conferences-app/src/screenshotTest/kotlin/io/ashdavies/party/gallery/GalleryScreenTests.kt

@@ -6,12 +6,12 @@ import io.ashdavies.party.tooling.MaterialPreviewTheme
 import io.ashdavies.party.tooling.PreviewDayNight
 import kotlinx.collections.immutable.persistentListOf
 
-internal class GalleryListTest {
+internal class GalleryScreenTests {
 
     @Composable
     @PreviewDayNight
     @OptIn(ExperimentalFoundationApi::class)
-    fun GalleryGridPreview() {
+    private fun GalleryGridPreview() {
         MaterialPreviewTheme {
             GalleryGrid(
                 itemList = persistentListOf(
@@ -29,7 +29,7 @@ internal class GalleryListTest {
 
     @Composable
     @PreviewDayNight
-    fun GalleryBottomSheetPreview() {
+    private fun GalleryBottomSheetPreview() {
         MaterialPreviewTheme {
             GallerySheetContent(eventSink = { })
         }

conferences-app/src/screenshotTest/kotlin/io/ashdavies/party/home/HomeScreenTests.kt

@@ -12,7 +12,7 @@ internal class HomeScreenTests {
     @Composable
     @PreviewDayNight
     @OptIn(ExperimentalMaterial3Api::class)
-    fun HomeTopAppBarPreview() {
+    private fun HomeTopAppBarPreview() {
         MaterialPreviewTheme {
             HomeTopBar(
                 actions = {
@@ -27,7 +27,7 @@ internal class HomeScreenTests {
 
     @Composable
     @PreviewDayNight
-    fun HomeBottomSheetPreview() {
+    private fun HomeBottomSheetPreview() {
         MaterialPreviewTheme {
             HomeBottomBar()
         }

detekt-config.yml

@@ -19,6 +19,8 @@ naming:
 style:
   MagicNumber:
     ignorePropertyDeclaration: true
+  UnusedPrivateMember:
+    ignoreAnnotated: ['Preview', 'PreviewDayNight']
   UnusedPrivateProperty:
     excludes:
       - '**/*.gradle.kts'