Upload artifact only on screenshot validation failure

ashdavies · Dec 9, 2024 · f892e64 · f892e64
1 parent 9ce9874
commit f892e64
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/.github/workflows/pull-request.yml b/.github/workflows/pull-request.yml
@@ -64,14 +64,15 @@ jobs:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
           SERVER_CLIENT_ID: ${{ secrets.SERVER_CLIENT_ID }}
 
-      - run: ./gradlew validateScreenshotTest --console=plain
+      - id: screenshot-validation
+        run: ./gradlew validateScreenshotTest --console=plain
         env:
           ANDROID_API_KEY: ${{ secrets.ANDROID_API_KEY }}
           BROWSER_API_KEY: ${{ secrets.BROWSER_API_KEY }}
           SERVER_CLIENT_ID: ${{ secrets.SERVER_CLIENT_ID }}
 
       - uses: actions/upload-artifact@v4
-        if: failure()
+        if: failure() && steps.screenshot-validation.outcome == "failure"
         with:
           if-no-files-found: error
           name: screenshot-test-report