Welcome to RectorPHP #307
Welcome to RectorPHP #307
Conversation
roberto-butti
commented
Jan 7, 2025
roberto-butti
commented
- added rector
- added ruleset for laravel
- using set code quality and dead code
There was a problem hiding this comment.
Hey @roberto-butti, huge thank you for this PR! I've just left a few small questions 😄
| __DIR__ . '/tests', | ||
| ]) | ||
| // uncomment to reach your current PHP version | ||
| //->withPhpSets(php80: true) |
There was a problem hiding this comment.
Am I right in assuming that we'd set the current PHP version as 8.1 here since that's the minimum version required for the package? 🙂
There was a problem hiding this comment.
Yes, I tried it, but it raised some other issues we need to address. So, to keep this specific PR small, I started with two simple rulesets. One of the great things of Rector is that you can introduce it in a project with just a few rules and then add more rules later, with a kind of "progressive" approach
| @@ -411,7 +411,7 @@ public function make(): ShortURL | |||
|
|
|||
| $shortURL = new ShortURL($data); | |||
|
|
|||
| if ($this->beforeCreateCallback) { | |||
| if ($this->beforeCreateCallback instanceof \Closure) { | |||
There was a problem hiding this comment.
I'm trying to make up my mind about whether I like this change. The beforeCreateCallback property can only be null or an instance of Closure. So I'm not sure how much value the additional instanceof check is adding other than making it more explicit.
But if there's a good reason for it, I'm more than happy to be persuaded that this will be a beneficial change 😄
There was a problem hiding this comment.
This is a more strict check.
This is introduced by the rulesetCodeQuality i set in the rector.php config.
The CodeQuality ruleset includes the two applied rules: FlipTypeControlToUseExclusiveTypeRector https://getrector.com/rule-detail/flip-type-control-to-use-exclusive-type-rector and ExplicitBoolCompareRector https://getrector.com/rule-detail/explicit-bool-compare-rector.
If you want to be more granular in the configuration, to control rules and not generic ruleset, you can use withRules instead of withPreparedSets
