Add support for PHP 8.4 #301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ash-jc-allen
changed the title
kyryl-bogach
reviewed
Dec 3, 2024
| @@ -24,7 +24,8 @@ | |||
| "illuminate/database": "^10.0|^11.0", | |||
| "hashids/hashids": "^4.0|^5.0", | |||
| "whichbrowser/parser": "^2.1", | |||
| "ashallendesign/laravel-config-validator": "^2.6.1" | |||
| "ashallendesign/laravel-config-validator": "^2.6.1", | |||
| "laravel/framework": "^10.0" | |||
There was a problem hiding this comment.
Do we really need this depedency? Wouldn't this mean that it would conflict with Laravel 11 installs?
There was a problem hiding this comment.
I basically can't upgrade to ^8.2 because of this.
There was a problem hiding this comment.
Hey @kyryl-bogach! Huge thank you for pointing this out to me. I was doing some tinkering the other day and accidentally committed this (I can't believe I did that!) 🤦♂️
I've just removed it now, so you should be able to upgrade to v8.2.1 🤞
Sorry about that!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.