Add migration to convert false tracking fields to null #272
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR piggy backs off the back off #244 to solve issue #243.
Currently, if the user agent parser can't detect data from the user agent string, the fields will be stored as
false
in theshort_url_visits
table. For example, if we can't detect the visitor's browser version, then thebrowser_version
field will be saved asfalse
.As of Short URL v8 (to be released shortly), this behaviour has slightly changed. Instead, we'll use
null
rather thanfalse
.This PR uses @stevebauman's proposed database migration that will update any existing rows that are using
false
to now benull
.I'm going to sit on this one for a day or so and try to get some other opinions. I'm worried about corrupting anyone's data! 🤯