Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add _IgnoreCustomTagsLoader and use it in load_yaml #1825

Merged
merged 3 commits into from
Aug 20, 2024
Merged

add _IgnoreCustomTagsLoader and use it in load_yaml #1825

merged 3 commits into from
Aug 20, 2024

Conversation

braingram
Copy link
Contributor

@braingram braingram commented Aug 14, 2024 •
edited
Loading

Description

This PR adds a new, private yaml loader _IgnoreCustomTagsLoader that allows load_yaml to handle recursive objects.

Romancal uses load_yaml so running tests here: https://github.com/spacetelescope/RegressionTests/actions/runs/10392788407

Fixes #1821

Checklist:

  • pre-commit checks ran successfully
  • tests ran successfully
  • for a public change, a changelog entry was added
  • for a public change, documentation was updated
  • for any new features, unit tests were added

@braingram braingram force-pushed the load_yaml_recursion branch from e00d37d to 6541f97 Compare August 19, 2024 20:02
@braingram braingram force-pushed the load_yaml_recursion branch 2 times, most recently from 63f8ab5 to a67f846 Compare August 20, 2024 14:53
@braingram braingram marked this pull request as ready for review August 20, 2024 14:53
@braingram braingram requested a review from a team as a code owner August 20, 2024 14:53
@zacharyburnett zacharyburnett changed the title add _IgnoreCustomTagsLoader and use it in load_yaml add _IgnoreCustomTagsLoader and use it in load_yaml Aug 20, 2024
@braingram braingram force-pushed the load_yaml_recursion branch from a67f846 to 196156f Compare August 20, 2024 19:23
@braingram braingram merged commit c5cb4da into asdf-format:main Aug 20, 2024
31 of 32 checks passed
@braingram braingram deleted the load_yaml_recursion branch August 20, 2024 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zacharyburnett zacharyburnett zacharyburnett approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

asdf.util.load_yaml fails on recursive object
2 participants
@braingram @zacharyburnett