update test warning filter for pytest 8 #1729
Conversation
braingram
force-pushed
the
pytest_8_warnings
branch
from
c1818f2 to
62acb1a
Compare
requirements-dev.txt
Outdated
| @@ -5,6 +5,8 @@ git+https://github.com/asdf-format/asdf-unit-schemas.git | |||
| git+https://github.com/asdf-format/asdf-wcs-schemas | |||
| git+https://github.com/yaml/pyyaml.git | |||
|
|
|||
| pytest>=0.0.dev0 | |||
There was a problem hiding this comment.
should we run this in a different dev test?
There was a problem hiding this comment.
Thanks for giving this a review.
That sounds like a great idea! It does seem bad to have all our devdeps fail just because pytest makes some change. I am planning to update #1731 and bring it out of draft after this PR is merged which would install pytest from dev (further increasing the risk of a change breaking all the tests).
Do you have a suggestion for how to break this out? Maybe update tox with a -pytestdev option and add it to the CI? Thanks in advance for your help :)
There was a problem hiding this comment.
yeah I think a -pytestdev tox factor is a good idea, because then we could also theoretically mix and match it with -devdeps or -stdevdeps
There was a problem hiding this comment.
Good point! I'll update this PR.
|
Thanks @zacharyburnett I switched to the |
pytest 8 includes a change to how "pytest.warns" behaves (it now re-emits non-matched warnings). Running the asdf test suite against pytest 8 (rc1) there is one failing test test_asdf_asdf_SerializationContext_import_deprecation due to this change.
This PR updates the warning filters in test_asdf_asdf_SerializationContext_import_deprecation to work with pytest 8.
This PR also adds pytest pre release testing to devdeps. Once this PR is merged #1731 can be updated to add pytest dev (perhaps in a separate tox environment) since asdf provides a pytest plugin and likely would benefit from testing against pytest dev.
Description
Checklist: