Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR starts the cleanup of the asdf api starting with the
asdf.util
submodule. This PR includes the following deprecations:human_list
(unused in downstream)resolve_name
andminversion
(these are out-dated copies fromastropy.utils
, the one use in the asdf pytest plugin was replaced, these methods are unused in downstream)iter_subclasses
(unused in downstream, replaced with_iter_subclasses
for internal uses)The following were not listed in
__all__
and are only used internally. Each was modified to be prefixed with an_
to make theirprivate
nature more explicit:BinaryStruct
InheritDocstrings
patched_urllib_parse
One addition was made to the public api:
get_file_type
andFileType
to__all__
(these are used by weldx and look generally useful for working with ASDF files as a way to check if a file is an ASDF file without some sort oftry/except
withasdf.open
)Once merged, tracking issues can be opened for the deprecations to plan for their removal in asdf 4.0.
Checklist: