switch IOBase to FileIO in test #1650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
braingram
added a commit
to braingram/asdf
that referenced
this pull request
Sep 29, 2023
switch IOBase to FileIO in test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing with python 3.12 in #1633 revealed an issue with one test that is using
IOBase. See comment: #1633 (comment)It appears that in python 3.12
IOBase.__init__no longer accepts accepts the same arguments. This appears to be an undocumented change (I can't seen to find any documentation) and I don't recall this occurring in rc1. The use ofIOBasein the test can be replaced withFileIO(which fits the usage better).This change is split from #1633 to make it easier to backport to 2.15.x