Merge pull request #1637 from braingram/remove_legacy_extension_api

Remove legacy extension api

CHANGES.rst

@@ -34,6 +34,7 @@ The ASDF Standard is at v1.6.0
 
 - Add support for python 3.12 [#1641]
 - Move IntegerType to converter and drop cache of converted values. [#1527]
+- Remove legacy extension API [#1637]
 
 2.15.1 (2023-08-07)
 -------------------

asdf/_tests/_helpers.py

@@ -24,11 +24,9 @@
 
 import asdf
 from asdf import generic_io, versioning
-from asdf._resolver import Resolver, ResolverChain
 from asdf.asdf import AsdfFile, get_asdf_library_info
 from asdf.constants import YAML_TAG_PREFIX
-from asdf.exceptions import AsdfConversionWarning, AsdfDeprecationWarning
-from asdf.extension import _legacy
+from asdf.exceptions import AsdfConversionWarning
 from asdf.tags.core import AsdfObject
 from asdf.versioning import (
     AsdfVersion,
@@ -97,20 +95,14 @@ def assert_tree_match(old_tree, new_tree, ctx=None, funcname="assert_equal", ign
         ignore_keys = ["asdf_library", "history"]
     ignore_keys = set(ignore_keys)
 
-    if ctx is None:
-        version_string = str(versioning.default_version)
-        ctx = _legacy.default_extensions.extension_list
-    else:
-        version_string = ctx.version_string
-
     def recurse(old, new):
         if id(old) in seen or id(new) in seen:
             return
         seen.add(id(old))
         seen.add(id(new))
 
-        old_type = ctx._type_index.from_custom_type(type(old), version_string)
-        new_type = ctx._type_index.from_custom_type(type(new), version_string)
+        old_type = None
+        new_type = None
 
         if (
             old_type is not None
@@ -418,35 +410,6 @@ def assert_no_warnings(warning_class=None):
         )
 
 
-def assert_extension_correctness(extension):
-    """
-    Assert that an ASDF extension's types are all correctly formed and
-    that the extension provides all of the required schemas.
-
-    Parameters
-    ----------
-    extension : asdf._AsdfExtension
-        The extension to validate
-    """
-    __tracebackhide__ = True
-
-    warnings.warn(
-        "assert_extension_correctness is deprecated and depends "
-        "on the deprecated type system. Please use the new "
-        "extension API: "
-        "https://asdf.readthedocs.io/en/stable/asdf/extending/converters.html",
-        AsdfDeprecationWarning,
-    )
-
-    resolver = ResolverChain(
-        Resolver(extension.tag_mapping, "tag"),
-        Resolver(extension.url_mapping, "url"),
-    )
-
-    for extension_type in extension.types:
-        _assert_extension_type_correctness(extension, extension_type, resolver)
-
-
 def _assert_extension_type_correctness(extension, extension_type, resolver):
     __tracebackhide__ = True
 

asdf/_tests/commands/tests/test_extension.py

@@ -1,6 +1,7 @@
 import pytest
 
 from asdf.commands import find_extensions
+from asdf.versioning import supported_versions
 
 
 @pytest.mark.parametrize("summary", [True, False])
@@ -10,7 +11,8 @@ def test_parameter_combinations(summary, tags_only):
     find_extensions(summary, tags_only)
 
 
-def test_builtin_extension_included(capsys):
+@pytest.mark.parametrize("standard_version", supported_versions)
+def test_builtin_extension_included(capsys, standard_version):
     find_extensions(True, False)
     captured = capsys.readouterr()
-    assert "asdf.extension.BuiltinExtension" in captured.out
+    assert f"core-{standard_version}" in captured.out

asdf/_tests/commands/tests/test_tags.py

@@ -19,7 +19,5 @@ def test_all_tags_present():
     tags = {line.strip() for line in iostream.readlines()}
 
     af = AsdfFile()
-    for tag in af._type_index._type_by_tag:
-        assert tag in tags
     for tag in af.extension_manager._converters_by_tag:
         assert tag in tags