deprecate is_primitive

asdf/_tests/test_deprecated.py

@@ -2,6 +2,7 @@
 
 import pytest
 
+import asdf
 from asdf.exceptions import AsdfDeprecationWarning
 
 
@@ -15,3 +16,8 @@ def test_asdf_stream_deprecation():
 def test_asdf_asdf_SerializationContext_import_deprecation():
     with pytest.warns(AsdfDeprecationWarning, match="importing SerializationContext from asdf.asdf"):
         from asdf.asdf import SerializationContext  # noqa: F401
+
+
+def test_asdf_util_is_primitive_deprecation():
+    with pytest.warns(AsdfDeprecationWarning, match="asdf.util.is_primitive is deprecated"):
+        asdf.util.is_primitive(1)

asdf/_tests/test_util.py

@@ -1,16 +1,20 @@
 import io
+import warnings
 
 import pytest
 
 from asdf import generic_io, util
+from asdf.exceptions import AsdfDeprecationWarning
 
 
 def test_is_primitive():
-    for value in [None, "foo", 1, 1.39, 1 + 1j, True]:
-        assert util.is_primitive(value) is True
+    with warnings.catch_warnings():
+        warnings.filterwarnings("ignore", "asdf.util.is_primitive is deprecated", AsdfDeprecationWarning)
+        for value in [None, "foo", 1, 1.39, 1 + 1j, True]:
+            assert util.is_primitive(value) is True
 
-    for value in [[], (), {}, set()]:
-        assert util.is_primitive(value) is False
+        for value in [[], (), {}, set()]:
+            assert util.is_primitive(value) is False
 
 
 def test_not_set():

asdf/util.py

@@ -5,6 +5,7 @@
 import re
 import struct
 import types
+import warnings
 from functools import lru_cache
 from importlib import metadata
 from urllib.request import pathname2url
@@ -19,7 +20,7 @@
 from importlib_metadata import packages_distributions
 from packaging.version import Version
 
-from . import constants
+from . import constants, exceptions
 
 # We're importing our own copy of urllib.parse because
 # we need to patch it to support asdf:// URIs, but it'd
@@ -449,6 +450,7 @@ def is_primitive(value):
     bool
         True if the value is primitive, False otherwise
     """
+    warnings.warn("asdf.util.is_primitive is deprecated", exceptions.AsdfDeprecationWarning)
     return isinstance(value, (bool, int, float, complex, str)) or value is None