fixes #33: install from zip files #36
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucasmundim
approved these changes
Oct 19, 2022
|
Works for me. Can this be merged? Otherwise the plugin remains unusable on macOS. |
hleinone
approved these changes
Aug 12, 2024
machupicchubeta
added a commit
to machupicchubeta/dotfiles
that referenced
this pull request
Oct 14, 2024
When set up on macOS using asdf-flutter, a zip file is downloaded. However, asdf-flutter does not support zip files and an error occurs. There is the Issue and the Pull Request in the repository, but it has not been merged for more than 2 years. Maybe there is some reason why some environments reproduce the issue and others do not. Or maybe the repository is not maintained. See also: - https://docs.flutter.dev/get-started/install/macos/mobile-ios#download-then-install-flutter - asdf-community/asdf-flutter#52 - asdf-community/asdf-flutter#33 - asdf-community/asdf-flutter#36
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure why the MacOS builds are sometimes zip files, but this PR should handle those cases.
unzipdoesn't have a--stripoption like tar, so it has to unzip to a tmp directory and then move the files over.