Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix getMessageIdByTimestamp cannot redirect #27

Merged
merged 2 commits into from
Nov 29, 2024

Conversation

liudezhi2098
Copy link

Motivation

https://github.com/apache/pulsar/blob/fd7e0b48fd766413759bbf53d9e7a4dcdcae995d/pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/v2/PersistentTopics.java#L1758-L1774
L1770 introduced by cherry-pick<apache#21995>, the forwarding will not be performed.

Modifications

adjust logic

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository:

@liudezhi2098 liudezhi2098 added bug Something isn't working released/2.10.7.5 labels Nov 29, 2024
@liudezhi2098 liudezhi2098 self-assigned this Nov 29, 2024
@liudezhi2098 liudezhi2098 merged commit 8ed1455 into branch-as-2.10 Nov 29, 2024
28 of 29 checks passed
@liudezhi2098 liudezhi2098 deleted the fix-branch-2.10-getmsgid branch November 29, 2024 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working released/2.10.7.5
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant