Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[improve][broker] Improve rgCalculatedQuota and rgRemoteUsageReports metrics #17

Merged

Conversation

nodece
Copy link
Collaborator

@nodece nodece commented May 29, 2024

Motivation

The following metric types should be gauge, not counter:

  • pulsar_resource_group_calculated_bytes_quota
  • pulsar_resource_group_calculated_messages_quota
  • pulsar_resource_group_remote_usage_messages_used
  • pulsar_resource_group_remote_usage_bytes_used

Modifications

  • Change these metric types from count to gauge
  • Add the counter metrics named with the suffix _total for these metrics

When upgrading to Pulsar 2.11 or higher, it is compatible.

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

@nodece
Copy link
Collaborator Author

nodece commented May 29, 2024

/pulsarbot rerun-failure-checks

@nodece nodece closed this May 29, 2024
@nodece nodece reopened this May 29, 2024
@nodece nodece force-pushed the improve-rgCalculatedQuota-metric branch from 0372fe8 to 973e717 Compare May 29, 2024 16:09
@nodece nodece changed the title [improve][broker] Change rgCalculatedQuotaBytes and rgCalculatedQuotaMessages types to gauge [improve][broker] Improve rgCalculatedQuota and rgRemoteUsageReports metrics May 29, 2024
@nodece nodece merged commit 3c76893 into ascentstream:branch-as-2.10 May 30, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant