Supply the transition hooks with more data #29
+39
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jezzdk
force-pushed
the
feature/send-more-data-to-hooks
branch
from
e304e6c to
b06d42e
Compare
|
I dont think this will ever gets merged since you are replacing the current database migration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Currently it's very difficult to pass data to transition hooks. I have this problem when I want to make a transition and the hooks depend on data that was sent in the request. Currently I have to save the request data on the model, even though it's not necessary to save it in the database. This change will allow more data to be sent to transition hooks.
Type of Change