Fix TestFilesystem::read_dir_diff_paths #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry, I accidentally closed this PR's predecessor by deleting the branch on my fork. |
arxanas
approved these changes
May 7, 2024
This function collects the files present in the `left` and `right` directories. It should return the path suffix with the `left` and `right` prefix stripped. This is necessary because `process_opts` will add the `left` and `right` prefix back to the paths returned by `read_dir_diff_paths`. If we don't strip the prefix, we will end up with invalid paths where the prefix is duplicated. This went unnoticed since the current tests don't diff directories. I will add a test that diffs directories in a subsequent commit.
emesterhazy
force-pushed
the
push-snkowsyywvlm
branch
from
0c23fc3 to
52a2aa8
Compare
arxanas
approved these changes
May 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This function collects the files present in the
leftandrightdirectories. It should return the path suffix with theleftandrightprefix stripped. This is necessary becauseprocess_optswill add theleftandrightprefix back to the paths returned byread_dir_diff_paths. If we don't strip the prefix, we will end up with invalid paths where the prefix is duplicated.This went unnoticed since the current tests don't diff directories. I will add a test that diffs directories in a subsequent commit.