Add pre-commit #19
Merged
Add pre-commit #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Adding `pre-commit` to the repository. The new `pre-commit` directives can be found in the configuration file `.pre-commit-config.yaml`. - Removed excess ignore items in the `.gitignore` for simplicity. - Added `.taplo.toml` to enforce TOML file formatting. - Updated the readme for the new pre-commit hooks. - Updated the pyproject.toml file with pre-commit configuration, as well as removing the tools handled by pre-commit from the dev install directive. Resolves #13
|
Note that none of these hooks have been run on the codebase yet. That will be done in the issue #20 |
aloctavodia
reviewed
Jun 30, 2023
|
thanks for the reminder, I'll update for that as well |
|
I left it as a flake8 error when prints are found. I think blindly removing print statements is not the greatest of dev experiences, as it removes the opportunity to convert them to a log. We should discuss adding checks for |
aloctavodia
approved these changes
Jun 30, 2023
yilinxia
approved these changes
Jun 30, 2023
|
good catch, made an issue to remove it #22 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pre-committo the repository. The newpre-commitdirectives can be found in the configuration file.pre-commit-config.yaml..gitignorefor simplicity..taplo.tomlto enforce TOML file formatting.Resolves #13