Argo

[Theodore-Chatziioannou]

Initial commit of the gtfs_skims (or argo) library.

Checklist

Any checks which are not relevant to the PR can be pre-checked by the PR creator.
All others should be checked by the reviewer(s).
You can add extra checklist items here if required by the PR.

• CHANGELOG updated
• Tests added to cover contribution
• Documentation updated

[brynpickering]

What does ARGO stand for?

[brynpickering]

Looks really good - Glad to see you're following the template structure and documenting+testing as you go along.

My comments are mostly minor details about design choice, some of which you can happily ignore if you wish.

I think this repo would benefit from a YAML schema to go along with the config file. This ensures that the config file is correctly structured (including data types etc) and can even be rendered in the documentation so that users can read what the parameters are.

You can find an example YAML schema here: https://github.com/calliope-project/euro-calliope/blob/develop/config/schema.yaml and here: https://github.com/calliope-project/calliope/blob/main/src/calliope/config/math_schema.yaml

And process to render it in the docs, e.g.: https://github.com/calliope-project/euro-calliope/blob/develop/lib/eurocalliopelib/docs/schema.py

I can help on that in a later PR if it helps (would be good to have an example to then use in other repos with config files)

[Theodore-Chatziioannou]

@brynpickering I like the idea of writing a config schema as a separate PR. If you are happy with the updates, let's merge this PR and I will open another.

[brynpickering]

@Theodore-Chatziioannou I tested locally and came across an issue I've had in GeNet (see arup-group/genet#213). It's related to SSL certs that seems to be a bug. The fix suppresses PROJ's attempt to make a network connection and will likely circumvent other people within the org coming across a similar issue when running it locally.

[Theodore-Chatziioannou]

@neilmt @val-ismaili I am merging this, but it would be good to capture any domain/user feedback separately. Please add any such feedback as github issues.