feat(20): add lambda image #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mloberg
force-pushed
the
feature/node-20-lambda
branch
from
d104671 to
f8035a5
Compare
Dbaker1298
previously approved these changes
Nov 13, 2023
juniormince
reviewed
Nov 13, 2023
|
Or sorry that's vague I mean is it replacing that other node-20 image or are they for different purposes, haven't dug into it just saw 20 already existed |
|
Oh just kidding just kidding my eyes skimmed over "lambda" because I was trying to comment quickly before investigating too much and was confused by the change in dir/ formatting with 20 so I wanted to ask before it got merged. Looks good! Only other question:
|
juniormince
previously approved these changes
Nov 13, 2023
Add pull request template to make sure README is updated Mark 20 as the recommended image
|
@juniormince The new ignore is for dnf. Each package manager must have their own number and since we're adding dnf for lambda, we need to add that ignore |
Dbaker1298
approved these changes
Nov 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add pull request template to make sure all the new image things are done (mostly README, which I forgot about initially)