Add a "Exists" function to fsutil #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sevein
reviewed
Nov 6, 2024
There was a problem hiding this comment.
A couple of suggestions:
- Renaming the method to
fsutil.Existswould clarify that it checks for both files and directories, treating them the same way. - We should avoid hiding the error because changing the function's signature later to include it would be a backward-incompatible change. Here's an example that you could use. Users can still choose to ignore the error if it's not needed.
|
@sevein okay, done. |
Exists returns true if a file or directory exist at the given path and false if one doesn't.
djjuhasz
force-pushed
the
dev/add-fsutil-file-exists
branch
from
628176a to
3d188fc
Compare
djjuhasz
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I copied the
FileExists()function from https://github.com/artefactual-sdps/preprocessing-sfa/blob/main/internal/fsutil/fsutil.go. I need the function in https://github.com/artefactual-sdps/preprocessing-demo and I think we've re-implemented it in several other projects, so I think it's a good candidate for gotools.