Matrix factorization and decomposition tests #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
syurkevi
force-pushed
the
matrix_fact_an_dec_tests
branch
from
5f2bf49 to
3ee277c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a suite of unit tests for the matrix_factorization_and_decomposition.py located within the within the linear_algebra directory. The primary function in this file facilitate the basic matrix operations that can be carried out including finding the cholesky decomposition , cholesky inplace decomposition, lu decompsition, lu inplace decomposition, qr decomposition, qr inplace decomposition, svd decomposition, and svd in place decomposition.
Shape: Ensures that the functions can handle correctly instantiated shapes.
Dim: Ensures that functions which can't handle batch inputs can properly handle these types of inputs
Dtype: Ensures that any dtype outside of float/complex types will be properly handled
Data Type Accuracy: Ensures that the resulting output data types for each function are correct
Error Handling: Assesses the function's error handling