-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Documentation: composes a blog post for arquillian kube recipes. #410
Conversation
@lordofthejars, @bartoszmajsak, @MatousJobanek - Please review the blog post for Arquillian Kube Recipes. |
Don't worry about the build failing for now - need to fix release generation. |
|
||
*For a more in-depth step by step coverage of deployment testing, continue reading below.* | ||
|
||
*Step 1: Building Docker Images and creating Resource Descriptors.* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This Step 1 is a really concrete example of using f8 maven plugin to generate resources, since Example 3 is about this concrete case, what I would do is just remove this step since it is not mandatory.
There is an issue with the tests for this blog post, as we assume that each is a release announcement. Can you fix the tests to unblock the build? Created issue for that #412 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
experience for writing integration tests with ease by bringing their tests to the real environment and | ||
deploy with confidence like never before. | ||
|
||
With this blog post, we aim at showcasing integration tests for your Kubernetes or OpenShift clusters using just "Arquillian Cube":https://github.com/arquillian/arquillian-kube. Moving a step further, we also demonstrate building and deploying from scratch, applications with no deployment configuration, leveraging the power of "Fabric8 Maven Plugin":https://maven.fabric8.io/ along with the Arquillian Kube Extension. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are we referring to "Kube" as an extension - isn't it Cube?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We separated Kubernetes and Openshift related content to a separate extension "Kube" sometime back. But I am not sure, what to refer here.
@lordofthejars, what do you suggest ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we only did that change on the documentation level.
|
||
With this blog post, we aim at showcasing integration tests for your Kubernetes or OpenShift clusters using just "Arquillian Cube":https://github.com/arquillian/arquillian-kube. Moving a step further, we also demonstrate building and deploying from scratch, applications with no deployment configuration, leveraging the power of "Fabric8 Maven Plugin":https://maven.fabric8.io/ along with the Arquillian Kube Extension. | ||
|
||
h2. Deployment Testing Recipes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we should emphasize on why such tests are useful? I'm missing a clear goal for that.
</dependencies> | ||
</dependencyManagement> | ||
|
||
h4. Arquillian Cube Requirement |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We mention this, but it's not explained why we need that library in the post.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lordofthejars, I am not sure of the answer, can you please help me with the answer.
why we need that library
Test Enrichers like @RouteURL further aid in injection of container resources like route to the deployed service. | ||
For farbric8 maven plugin to identify the route, @RouteURL should be set to artifactId of the project by | ||
default, or explicity configured otherwise. | ||
# *Adding Test Cases that assert environment is in the expected state*. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is (5)
element on the list, but the code above has only four references.
</executions> | ||
</plugin> | ||
|
||
p. For more and complete configuration details check out "fabric8 maven plugin documentation":https://maven.fabric8.io/. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm missing a nice wrap-up / closing statement for this blog post.
@bartoszmajsak , @lordofthejars - I also have another query, should we put examples before as is the case now, or later in the blog ? |
I think the structure of having overview with links first and then deeper dive is good in my opinion. |
Re-triggered the build. When it passes I will merge. Thank you @hemanik! |
Short description of what this resolves:
Composes a general blog post to generate awareness regarding the arquillian kube recipes .
Changes proposed in this pull request:
Fixes: arquillian/arquillian-cube#834