Fix slash command popup

arnoudkooi · Feb 21, 2024 · 968a203 · 968a203
1 parent 5e46f0f
commit 968a203
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 5 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,8 +1,13 @@
 # CHANGELOG.md
-## 7.3.1.0 (2024-02-19)
+
+## 7.3.1.1 (2024-02-21)
+Fixes / changes:
+  - Fix slash command not showing when not in Next Experience
+
+## 7.3.1.0 (2024-02-21)
 Features:
   - Node switching is improved and now supports ADCV2 loadbalancing instances. 
-  - Pa
+
 Fixes / changes:
   - Added md5.js script to support node switching
   - Added an extra way to suppress slash commands popup, in case event capturing does not work

diff --git a/inject.js b/inject.js
@@ -3073,7 +3073,7 @@ function snuSetShortCuts() {
                     if (path.length > 8 && path[2]?.className.includes('CodeMirror')) return //not in codemirror
                     event.preventDefault();
                     //in some browsers the event KEYBOARD_SHORTCUTS_BEHAVIOR#MODAL_OPENED event can't be captured. this is a temporary fallback
-                    var showingPopup = window.top.querySelectorShadowDom.querySelectorDeep('.keyboard-shortcuts-modal'); //washington shortcuts popup 
+                    var showingPopup = window.top?.querySelectorShadowDom?.querySelectorDeep('.keyboard-shortcuts-modal'); //washington shortcuts popup 
                     if (showingPopup) event.preventDefault(); //don show when already visible
                     setTimeout(() => {
                         var showingPopup = window.top.querySelectorShadowDom.querySelectorDeep('.keyboard-shortcuts-modal'); //washington shortcuts popup 

diff --git a/manifest.json b/manifest.json
@@ -3,7 +3,7 @@
     "short_name": "SN Utils",
     "description": "Productivity tools for ServiceNow. (Personal work, not affiliated to ServiceNow)",
     "author": "Arnoud Kooi / arnoudkooi.com",
-    "version": "7.3.1.0",
+    "version": "7.3.1.1",
     "manifest_version": 3,
     "permissions": [
       "activeTab",

diff --git a/publish.sh b/publish.sh
@@ -49,7 +49,7 @@ lastpublishedversion=`cat publish/lastpublishedversion.txt`
 if [ "$lastpublishedversion" = "$currentversion" ]; then
     echo "Can not publish, version not updated in manifest.json: $currentversion"
 else
-    #node publish/publish.mjs
+    node publish/publish.mjs
     echo "Publishing: $currentversion"
     echo "$currentversion" > publish/lastpublishedversion.txt #write version to file
 fi