Bugfix v8.2.3.1

arnoudkooi · Oct 29, 2024 · 6605dab · 6605dab
1 parent fc1725c
commit 6605dab
Show file tree

Hide file tree

Showing 4 changed files with 32 additions and 16 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,4 +1,8 @@
 # CHANGELOG.md
+## 8.2.3.1 (2024-10-29)
+Fixes / changes:
+  - Bugfix for new setting edittor
+
 ## 8.2.3.0 (2024-10-28)
 Features:
   - Moving the advanced slashcommand and slasswitches editing to Monaco editor in a new browser tab

diff --git a/js/monaco/settingeditor.js b/js/monaco/settingeditor.js
@@ -122,27 +122,39 @@ function getFromChromeStorageGlobal(theName, callback) {
 
 function saveSettings() {
 
-    const jsonSetting = JSON.parse(editor.getValue());
-    const minifiedSetting = JSON.stringify(jsonSetting);
+    let jsonSetting;
+    let minifiedSetting;
+
+    try {
+        jsonSetting = JSON.parse(editor.getValue());
+        minifiedSetting  = JSON.stringify(jsonSetting);
+    } catch (e) {
+        document.querySelector('#response').innerHTML = `Error: Invalid JSON`;
+        document.querySelector('#response').title = `Error: ${e}`;
+        return;
+    }
 
     getFromSyncStorageGlobal("snusettings", function (data) { //get the current settings in case it was edited in the popup
         snusettingsSync = data;
         snusettingsSync[setting] = minifiedSetting;
-
         snusettings = {};
 
-        Object.keys(snusettingsSync).forEach(key => {
-            if (key.length >= 5000) { //overflow to local storage #204
-                snusettings[key] = '' + snusettingsSync[key];
-                delete snusettingsSync[key];
-            }
-        });
-
-        setToChromeSyncStorageGlobal("snusettings", snusettingsSync);
-        setToChromeStorageGlobal("snusettings", snusettings);
-
-        document.querySelector('#response').innerHTML = `Saved: ${new Date().toLocaleTimeString()}`;
-        versionid = getEditor().getModel().getAlternativeVersionId();
+        try {
+            Object.keys(snusettingsSync).forEach(key => {
+                if (snusettingsSync[key].length >= 5000) { //overflow to local storage #204
+                    snusettings[key] = '' + snusettingsSync[key];
+                    delete snusettingsSync[key];
+                }
+            });
+
+            setToChromeSyncStorageGlobal("snusettings", snusettingsSync);
+            setToChromeStorageGlobal("snusettings", snusettings);
+
+            document.querySelector('#response').innerHTML = `Saved: ${new Date().toLocaleTimeString()}`;
+            versionid = getEditor().getModel().getAlternativeVersionId();
+        } catch (e) {
+            document.querySelector('#response').innerHTML = `Error: ${e}`;
+        }
 
     })
 

diff --git a/js/monaco/vs/language/typescript/tsWorker.js → ...naco/vs/language/typescript/tsWorker 2.js b/js/monaco/vs/language/typescript/tsWorker.js → ...naco/vs/language/typescript/tsWorker 2.js
diff --git a/manifest.json b/manifest.json
@@ -3,7 +3,7 @@
     "short_name": "SN Utils",
     "description": "Productivity tools for ServiceNow. (Personal work, not affiliated to ServiceNow)",
     "author": "Arnoud Kooi / arnoudkooi.com",
-    "version": "8.2.2.1",
+    "version": "8.2.3.1",
     "manifest_version": 3, 
     "permissions": [
       "activeTab",