Update data plotly asset path for LWC 3.8.4 + IGN data as objet #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nworr
changed the title
nboisteault
requested changes
Jan 23, 2025
| if (file_exists(jApp::wwwPath('assets/js/dataviz/plotly-custom.min.js'))) { | ||
| $js[] = $bp.'assets/js/dataviz/plotly-custom.min.js'; | ||
| $js[] = $bp.'js/dataviz/dataviz.js'; | ||
| } | ||
| if (file_exists(jApp::wwwPath('assets/js/dataviz/plotly-latest.min.js'))) { |
There was a problem hiding this comment.
Suggested change
| if (file_exists(jApp::wwwPath('assets/js/dataviz/plotly-latest.min.js'))) { | |
| elseif (file_exists(jApp::wwwPath('assets/js/dataviz/plotly-latest.min.js'))) { |
nworr
force-pushed
the
alti-profil-lwc8-5-plotly
branch
from
b7975d5 to
cf7f2ec
Compare
nworr
force-pushed
the
alti-profil-lwc8-5-plotly
branch
from
cf7f2ec to
3f7373a
Compare
|
#55 may be related |
nboisteault
approved these changes
Jan 27, 2025
Gustry
approved these changes
Jan 27, 2025
| }else{ | ||
| $errorMsg = "AltiProfil IGN wrong request"; | ||
| \jLog::log($errorMsg); | ||
| return '{"error msg": "'.$data.'" }'; |
There was a problem hiding this comment.
Side note, but it would be nice to edit the docstring at the same time, to help IDE with functions, code quality, QA tools such as PHP Stan (later, not yet added I know) ;-)
Co-authored-by: Étienne Trimaille <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since LWC 3.8.4
data-plotlyjs file is namedplotly-custom.min.js(3liz/lizmap-web-client@1311074)Use proper Proxy Class
For IGN provider : add json_encode to data , since request content is no more "JSON parsed" on js side