Important fixes for ArmorPaint + suggestion #1799
Open
+28
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The first of many bugs that ruin the workflow for some people, there *are* still bugs, but saving for the most part works now and creates files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regression fixes, particularly saving projects in the first place for ArmorPaint, and I would like to make a suggestion: Runtime tests.
Since the code before this fix managed to find its way to the stores, I'd like to see some tests, if a build fails a runtime test, I feel like it should not go on the store until it is fixed and passing, to reduce regressions like this. I don't know how y'all are going to do that but the tests that I can think of right now is:
I want to see this project thrive, especially since no other open source project like this exist, and the only other player in this space is a paid software that I don't want to pay for. Thank you!