Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add instance_port and permissions to the Application resource, allow updating applications. #15

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

yoo
Copy link

@yoo yoo commented Mar 14, 2019

This PR adds instance_port and permissions to the application resource schema.
In addition it implements the the resourceApplicationUpdate function to allow terraform to update a spinnaker application.

This PR includes a dirty hack, which I'm happy to fix if someone knows how.
When adding permissions to an application, on create, the permissions are not visible to
the Gate API and terraform receives an HTTP 403 when trying to read the application.
Terraform needs to wait until the cache is refreshed, but it dose not know how long (cache timeout).
I didn't found a way to force a cache invalidation or refresh the cache before reading the application.

@ethanfrogers
Copy link
Contributor

@yoo sorry for the massive delay here. Let me do some testing with this. Is there any reason to favor this approach vs using something like this?

@nicholasgcoles
Copy link

@ethanfrogers @yoo anybody need some help on this?

@KhadijaBenAmmar
Copy link

Does this PR is going to be merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants