Local dev #27
Open
Local dev #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Python2 syntax is now the fallback.
…parse properly from what I can tell and now ioc_parser fully supports Python2 and Python3 - at least for HTML.
|
Was reading the Issue response regarding PyPDF2 vs. pdfminer. I understand the reason behind sticking with pdfminer, but feel it would be worthwhile to implementing a solution that addresses Python3 problems out of the box as well. |
| @@ -35,12 +35,16 @@ | |||
| # | |||
| ################################################################################################### | |||
|
|
|||
| #from __future__ import unicode_literals | |||
There was a problem hiding this comment.
Remnants of a change that was not kept. This line has no real purpose any longer and should not be merged.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made changes that fixed an error due to the mixture of tabs with white spaces. But the biggest change involved making modifications for adding support for both Python2 and Python3. This included dropping the unicode encoding in html_parser, adding an updated from of the StringIO module, and adding a few additional parenthesis that were missing from various print statements.
I would like to note that I've been testing only the HTML parsing with this pull request. Nothing else should be effected but I am still learning the build of this utility. I've been testing html pages from malware-traffic-analysis.net which is pulling in many FPs - something I plan on playing with the future.
Finally I made the default PDF parser PyPDF2 as it has python2&3 support where pdfminer does not.