-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge concepts and design into single document #374
base: main
Are you sure you want to change the base?
Conversation
docs/concepts.md
Outdated
|
||
A cluster spec contains desired settings when creating a new cluster. | ||
The Cluster Specification, also called the 'Base Cluster' contains the desired settings when creating a new cluster. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cluster Spec and Base Cluster are not identical, even if they have similarities. Why merge the concepts here? And why do all of this if this is going to be replaced by Cluster Templates?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
okay I fixed it to keep both in the concepts document. please take another look
|
||
To know more about 'Base Cluster', read about it [here](./baseclusters.md) | ||
|
||
## Cluster Chart |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The cluster chart is only used by gen1 clusters. Gen2 clusters created from base clusters don't use the cluster chart. It's confusing to describe both base clusters and cluster charts in the same document.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
okay then I will remove the cluster chart stuff from the 0.10 docs version, once I am able to see it on the doc site
Codecov Report
@@ Coverage Diff @@
## main #374 +/- ##
==========================================
+ Coverage 28.71% 29.35% +0.63%
==========================================
Files 25 25
Lines 1654 1618 -36
==========================================
Hits 475 475
+ Misses 1132 1096 -36
Partials 47 47
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Currently concepts and design are two separate documents, but with a lot of same or similar information, creating confusion.
Merging the content from the two into a single document, for simplification