Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add goreleaser github action #174

Merged
merged 3 commits into from
Aug 27, 2022
Merged

Conversation

Rohitrajak1807
Copy link
Member

@Rohitrajak1807 Rohitrajak1807 commented Aug 26, 2022

This partly fixes #60 Create Compiled Arlon CLI for Linux and the Build Infrastructure

goreleaser allows the Arlon team to publish releases on GitHub. The configuration is YAML based and feature rich.

Aha! Link: https://pf9.aha.io/features/ARLON-281

@Rohitrajak1807 Rohitrajak1807 added the enhancement New feature or request label Aug 26, 2022
@Rohitrajak1807 Rohitrajak1807 added this to the 0.9.0 milestone Aug 26, 2022
Copy link
Member

@cruizen cruizen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Look for additional review though since I am party to this.

Copy link
Member

@cruizen cruizen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested a minor change. Thanks for adding caching and getting this complete in a short time.

.goreleaser.yaml Outdated Show resolved Hide resolved
@cruizen cruizen requested a review from cre8minus1 August 26, 2022 14:00
@cruizen
Copy link
Member

cruizen commented Aug 26, 2022

@cre8minus1 , @bcle We can release a binary for Arlon CLI for Windows too using goreleaser. We have excluded it for now since Arlon has not been tested on Windows yet.

@Rohitrajak1807
Copy link
Member Author

Rohitrajak1807 commented Aug 26, 2022 via email

Copy link
Collaborator

@bcle bcle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See minor comment.

.github/workflows/goreleaser.yaml Outdated Show resolved Hide resolved
@Rohitrajak1807 Rohitrajak1807 merged commit 21846ae into main Aug 27, 2022
@Rohitrajak1807 Rohitrajak1807 deleted the private/Rohitrajak1807/ci branch August 27, 2022 07:19
cruizen pushed a commit that referenced this pull request Dec 16, 2022
* add goreleaser github action
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Create Compiled Arlon CLI for Linux and the Build Infrastructure
4 participants