[WIP] Remove associated OTR keys when account is removed #95
Conversation
vqhuy
changed the title
vqhuy
force-pushed
the
tic23675
branch
3 times, most recently
from
6f06513 to
5e5638f
Compare
chrome/content/otr.js
Outdated
| let newKey = new libOTR.s_pending_privkey_calc(); | ||
| newKey.accountname = libC.strdup(key.contents.accountname); | ||
| newKey.protocol = libC.strdup(key.contents.protocol); | ||
| newKey.privkey = key.contents.privkey; |
There was a problem hiding this comment.
I have trouble with this, would love to hear your ideas here. @arlolra
I tried with length = gcry_sexp_sprint(); gcry_sexp_new(newKey.privkey, key.contents.privkey, length, {0,1}) but it didn't work.
There was a problem hiding this comment.
I tried with
length = gcry_sexp_sprint();
I'm assuming you mean gcry_sexp_length?
gcry_sexp_new(newKey.privkey, key.contents.privkey, length, {0,1})but it didn't work.
The definition of gcry_sexp_new is such that the second argument is expected to be "its external representation" but here key.contents.privkey has already been parsed.
I would say to get it working with a memcpy for now.
There was a problem hiding this comment.
I'm assuming you mean
gcry_sexp_length?
Sorry, I should write it clearly. I meant length = gcry_sexp_sprint(privkey, {0,1,2,3}, null, 0). gcry_sexp_length doesn't seem to work here (gcry_sexp_length(key.contents.privkey) always returns 2).
Yeah, the calls to |
|
I think it works now. Tested with a Linux build applied TheTorProject/tor-messenger-build#15. |
We need to use memcpy instead of assigning the pointer directly https://github.com/arlolra/ctypes-otr/pull/95/files#diff-0ae302860237c1727af8cba50ff6e1c6R272. Currently the app crashes because of "double free" (perhaps).