This repository has been archived by the owner on Dec 18, 2023. It is now read-only.
Add BW6-767 curve and update BW6-761 to use the new bw6 model #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
use bls12-381 instead of 377 for test imports fix the inline comments with correct name and params Set the right base field Equation for base curve is y2 = x3 + 1 fill in pairing params adapt sage scripts with correct moduli calculate the correct cubic non residue correct the parameter B in the curve equation remove the specialized method for mult by nonresidue nonresidue is two, so default will be doubling calculate more correct parameters for fq3 `TRACE_MINUS_ONE_DIV_TWO` and `QUADRATIC_NONRESIDUE_TO_T` compute the right fq3 & fp6 frobenious coefficients calculate the cofactor for g1 use the g1 generator from gnark's fork use the right g2 equation g2 cofactor is slightly smaller than g1 cofactor get the g2 generators from gnark's fork update g1 and g2 curve info in the comments fill in `COFACTOR_INV` value for g1 fill in `COFACTOR_INV` value for g2
author information 2-adicity of the scalar field
This reverts commit 2b323db.
2. Curve specific hard part of the final exp moved from algebra
2. Miller loop params changed to the "unoptimized" version
mmagician
changed the title
mmagician
approved these changes
Mar 31, 2023
Pratyush
reviewed
Mar 31, 2023
Comment on lines
+20
to
+33
| const X: BigInteger = BigInt::new([ | ||
| 0xd201000000010000, | ||
| 0x0, | ||
| 0x0, | ||
| 0x0, | ||
| 0x0, | ||
| 0x0, | ||
| 0x0, | ||
| 0x0, | ||
| 0x0, | ||
| 0x0, | ||
| 0x0, | ||
| 0x0, | ||
| ]); |
There was a problem hiding this comment.
We can use the BigInt macro to avoid having to do this manual specification. Though right now the macro does not handle hexadecimal inputs. I can submit a PR for this though.
There was a problem hiding this comment.
@swasilyev you should be able to now use updated macro from Pratyush's new PR in algebra: arkworks-rs/algebra#635
There was a problem hiding this comment.
We've discussed with @swasilyev to leave it as-is in this PR, and later to submit another PR where we use the macro for ALL curves.
There was a problem hiding this comment.
Created an issue for this: #169
This was referenced Apr 2, 2023
6 tasks
4 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Completes #154, requires arkworks-rs/algebra#633
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
Pendingsection inCHANGELOG.mdFiles changedin the Github PR explorer