Skip to content
This repository has been archived by the owner on Dec 18, 2023. It is now read-only.

Bw6-761 optimized Miller loop #155

Merged
merged 6 commits into from
Sep 3, 2023
Merged

Bw6-761 optimized Miller loop #155

merged 6 commits into from
Sep 3, 2023

Conversation

mmagician
Copy link
Member

Description

Companion to arkworks-rs/algebra#617


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (master)
  • Linked to Github issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Wrote unit tests
  • Updated relevant documentation in the code
  • Added a relevant changelog entry to the Pending section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

@weikengchen
Copy link
Member

weikengchen commented Mar 11, 2023

Just to check: is the pairing equivalent or not? --- latter would be breaking.

@mmagician
Copy link
Member Author

The pairing's equivalent. But you bring up a good point - the parameters for the Miller loop need to be adjusted, so maybe the ec change should be considered as a breaking change?
This would only be breaking if someone had their own implementation of another bw6 curve and was already using arkworks 0.4+. In the end, we should probably stick to best practices though.

@weikengchen
Copy link
Member

If the pairing is equivalent, then I think it would be completely okay---we do this, but just leave a changelog entry that the parameters have been changed.

@weikengchen
Copy link
Member

^ and in this case, ec change should surely be a breaking change.

@weikengchen
Copy link
Member

I believe we can merge this one first and then see if the test in the algebra passes.

@Pratyush
Copy link
Member

Pratyush commented Sep 1, 2023

@mmagician Let's merge this once the parameters are updated.

@mmagician
Copy link
Member Author

I temporarily switched to a branch bw6-optimization from algebra - this should allow us to verify that all tests are indeed passing, and once this PR is merged, we can also merge arkworks-rs/algebra#617, and finally update the patch.

@Pratyush Pratyush merged commit 1ce1fcf into master Sep 3, 2023
32 checks passed
@Pratyush Pratyush deleted the bw6-761-opt branch September 3, 2023 13:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants