-
Notifications
You must be signed in to change notification settings - Fork 254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: small adjustments #894
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR, this is great! If you could propagate this to the other crates in the repo as well that would be lovely =). We should also add it to the template https://github.com/arkworks-rs/template so that future repos will inherit it
@Pratyush Yes no problem, will propagate this in follow up PRs, one for each crate so that we have an easier review each time :) |
Description
@Pratyush Here I propose a slightly different formalism to manage lints compared to what we had before on the repo. This formalism inherits from what is already done on reth https://github.com/paradigmxyz/reth/blob/83af493179393c81dc2c48374306f2b88cc075db/Cargo.toml#L160-L254 with a curated list of lints that have already proven themselves.
In this methodology, lints are directly introduced into the cargo.toml file and then dispatched to all the crates inside the repo via
So it's easier to manage and more uniform. For now I have only applied it to the poly crate but we can adopt this for the other crates in follow up PRs if you agree.
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
Pending
section inCHANGELOG.md
Files changed
in the GitHub PR explorer