New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: improve codebase with some clippy suggestions #867

Merged

Pratyush merged 14 commits into arkworks-rs:master from tcoratger:clippy-suggestion

Nov 20, 2024

Contributor

tcoratger commented Nov 12, 2024 •

edited

Loading

Description

I think this can't be properly caught by the CI before we bump Rust to something like 1.82 but these suggestions still apply and simplify the codebase

Targeted PR against correct branch (master)
Linked to GitHub issue with discussion and accepted design OR have an explanation in the PR that describes this work.
Wrote unit tests
Updated relevant documentation in the code
Added a relevant changelog entry to the Pending section in CHANGELOG.md
Re-reviewed Files changed in the GitHub PR explorer


          chore: improve codebase with some clippy suggestions

4af0174

tcoratger requested review from a team as code owners

November 12, 2024 15:53

tcoratger requested review from z-tech, weikengchen and tyshko-rostyslav and removed request for a team

November 12, 2024 15:53

Contributor Author

tcoratger commented Nov 12, 2024

@Pratyush let me know if you want to merge this, even if the automatic detection for the future cannot be automated with clippy by the CI before we bump rust, I think this PR only brings simplifications :)


          Merge branch 'master' into clippy-suggestion

58cd422

Pratyush reviewed

View reviewed changes

ec/src/hashing/curve_maps/wb.rs Outdated Show resolved Hide resolved

Pratyush reviewed

View reviewed changes

ec/src/hashing/tests.rs Outdated Show resolved Hide resolved

Pratyush reviewed

View reviewed changes

ec/src/hashing/tests.rs Outdated Show resolved Hide resolved

Pratyush reviewed

View reviewed changes

ec/src/hashing/tests.rs Outdated Show resolved Hide resolved

Pratyush reviewed

View reviewed changes

ec/src/models/bw6/mod.rs Show resolved Hide resolved

Pratyush reviewed

View reviewed changes

ec/src/scalar_mul/glv.rs Outdated Show resolved Hide resolved

Pratyush reviewed

View reviewed changes

ec/src/scalar_mul/mod.rs Show resolved Hide resolved

Pratyush reviewed

View reviewed changes

ff/src/biginteger/tests.rs Outdated Show resolved Hide resolved

Pratyush reviewed

View reviewed changes

poly/src/evaluations/multivariate/multilinear/dense.rs Show resolved Hide resolved

Pratyush reviewed

View reviewed changes

poly/src/polynomial/univariate/sparse.rs Show resolved Hide resolved

Pratyush approved these changes

View reviewed changes

Pratyush self-requested a review

November 14, 2024 15:06

Pratyush requested changes

View reviewed changes

Member

Pratyush left a comment

Thanks for the PR! Just some small comments

Pratyush enabled auto-merge

November 14, 2024 15:07

tcoratger commented

View reviewed changes

ec/src/hashing/tests.rs Outdated Show resolved Hide resolved

ec/src/hashing/tests.rs Outdated Show resolved Hide resolved

ec/src/hashing/tests.rs Outdated Show resolved Hide resolved

ec/src/models/bw6/mod.rs Show resolved Hide resolved

ff/src/biginteger/tests.rs Outdated Show resolved Hide resolved


          Update ec/src/hashing/tests.rs

78ca410

auto-merge was automatically disabled

November 14, 2024 15:10

Head branch was pushed to by a user without write access

tcoratger added 3 commits

November 14, 2024 16:10


          Update ec/src/hashing/tests.rs

5cf467b


          Update ec/src/hashing/tests.rs

0c08b9f


          Update ff/src/biginteger/tests.rs

79eeaf2

tcoratger commented

View reviewed changes

ec/src/hashing/curve_maps/wb.rs Outdated Show resolved Hide resolved

tcoratger and others added 3 commits

November 14, 2024 16:12


          Update ec/src/hashing/curve_maps/wb.rs

e02749f


          fix comments

53a9452


          Merge branch 'master' into clippy-suggestion

77a3a02

Contributor Author

tcoratger commented Nov 14, 2024

Thanks for the PR! Just some small comments

@Pratyush Should be all fixed, let me know if something is missing :)


          Merge branch 'master' into clippy-suggestion

b4a54f7

Pratyush approved these changes

View reviewed changes

ff/src/biginteger/tests.rs Outdated Show resolved Hide resolved

ff/src/biginteger/tests.rs Outdated Show resolved Hide resolved

ff/src/biginteger/tests.rs Outdated Show resolved Hide resolved

ff/src/biginteger/tests.rs Outdated Show resolved Hide resolved

tcoratger and others added 4 commits

November 20, 2024 18:55


          Update ff/src/biginteger/tests.rs

d458cdc

Co-authored-by: Pratyush Mishra <[email protected]>


          Update ff/src/biginteger/tests.rs

1f176e3

Co-authored-by: Pratyush Mishra <[email protected]>


          Update ff/src/biginteger/tests.rs

215c1bf

Co-authored-by: Pratyush Mishra <[email protected]>


          Update ff/src/biginteger/tests.rs

3ee8438

Co-authored-by: Pratyush Mishra <[email protected]>

Pratyush enabled auto-merge

November 20, 2024 17:55

Contributor Author

tcoratger commented Nov 20, 2024

@Pratyush ci failure seems unrelated no?

Pratyush added this pull request to the merge queue

Merged via the queue into arkworks-rs:master with commit 902ca31

36 of 37 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Pratyush Pratyush approved these changes

z-tech Awaiting requested review from z-tech z-tech is a code owner automatically assigned from arkworks-rs/maintainers

weikengchen Awaiting requested review from weikengchen weikengchen is a code owner automatically assigned from arkworks-rs/maintainers

tyshko-rostyslav Awaiting requested review from tyshko-rostyslav tyshko-rostyslav is a code owner automatically assigned from arkworks-rs/maintainers

Labels

None yet