ec: small refactor for scalar_decomposition (#898)

arkworks-rs · Nov 30, 2024 · b1c8962 · b1c8962
1 parent 6272bcb
commit b1c8962
Showing 1 changed file with 3 additions and 5 deletions.
diff --git a/ec/src/scalar_mul/glv.rs b/ec/src/scalar_mul/glv.rs
@@ -31,13 +31,11 @@ pub trait GLVConfig: Send + Sync + 'static + SWCurveConfig {
     ) -> ((bool, Self::ScalarField), (bool, Self::ScalarField)) {
         let scalar: BigInt = k.into_bigint().into().into();
 
-        let coeff_bigints: [BigInt; 4] = Self::SCALAR_DECOMP_COEFFS.map(|x| {
+        let [n11, n12, n21, n22] = Self::SCALAR_DECOMP_COEFFS.map(|x| {
             let sign = if x.0 { Sign::Plus } else { Sign::Minus };
             BigInt::from_biguint(sign, x.1.into())
         });
 
-        let [n11, n12, n21, n22] = coeff_bigints;
-
         let r = BigInt::from(Self::ScalarField::MODULUS.into());
 
         // beta = vector([k,0]) * self.curve.N_inv
@@ -81,8 +79,8 @@ pub trait GLVConfig: Send + Sync + 'static + SWCurveConfig {
         let k2_abs = BigUint::try_from(k2.abs()).unwrap();
 
         (
-            (k1.sign() == Sign::Plus, Self::ScalarField::from(k1_abs)),
-            (k2.sign() == Sign::Plus, Self::ScalarField::from(k2_abs)),
+            (k1.sign() == Sign::Plus, k1_abs.into()),
+            (k2.sign() == Sign::Plus, k2_abs.into()),
         )
     }