Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debug the dyn.pl.kinetic_curves() #587

Merged
merged 4 commits into from
Oct 11, 2023
Merged

Conversation

Sichao25
Copy link
Collaborator

@Sichao25 Sichao25 commented Oct 6, 2023

Debug several issues related to kinetic_curves:

  • exprs calculation from umap inverse transform doesn't work.
  • exprs and time are not correctly indexed in fetch_exprs()
  • valid_genes output lost the input order discussed here.
  • ddhodge need a basis parameter.

@codecov-commenter
Copy link

codecov-commenter commented Oct 6, 2023

Codecov Report

Merging #587 (3f066cb) into master (f1f1584) will decrease coverage by 0.01%.
Report is 7 commits behind head on master.
The diff coverage is 0.00%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@            Coverage Diff             @@
##           master     #587      +/-   ##
==========================================
- Coverage   22.32%   22.32%   -0.01%     
==========================================
  Files         158      158              
  Lines       26356    26360       +4     
==========================================
  Hits         5885     5885              
- Misses      20471    20475       +4     
Files Coverage Δ
dynamo/plot/time_series.py 7.60% <0.00%> (-0.03%) ⬇️
dynamo/prediction/utils.py 7.82% <0.00%> (ø)
dynamo/prediction/fate.py 9.54% <0.00%> (-0.05%) ⬇️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Xiaojieqiu
Copy link
Collaborator

is this ready for review? @Sichao25

@Sichao25
Copy link
Collaborator Author

Sichao25 commented Oct 9, 2023

Yes, it is ready for review right now.

@Sichao25 Sichao25 marked this pull request as ready for review October 9, 2023 13:57
@Xiaojieqiu Xiaojieqiu merged commit 92e3687 into aristoteleo:master Oct 11, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants