Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debug arclength_sampling #586

Merged
merged 1 commit into from
Oct 11, 2023
Merged

Debug arclength_sampling #586

merged 1 commit into from
Oct 11, 2023

Conversation

Sichao25
Copy link
Collaborator

@Sichao25 Sichao25 commented Oct 6, 2023

arclength_sampling uniformly samples data points on an arc curve that is generated from vector field predictions. However, it may terminate earlier than expected, resulting in inconsistent shapes in the output.

Proposed solution: When the length of output is smaller than expected, calculate a new point with the last set of parameters.

@codecov-commenter
Copy link

codecov-commenter commented Oct 6, 2023

Codecov Report

Merging #586 (ddb3077) into master (153f5b7) will decrease coverage by 0.01%.
The diff coverage is 5.88%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@            Coverage Diff             @@
##           master     #586      +/-   ##
==========================================
- Coverage   22.32%   22.32%   -0.01%     
==========================================
  Files         158      158              
  Lines       26356    26362       +6     
==========================================
  Hits         5885     5885              
- Misses      20471    20477       +6     
Files Coverage Δ
dynamo/prediction/state_graph.py 12.42% <0.00%> (ø)
dynamo/prediction/utils.py 7.69% <6.25%> (-0.13%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Sichao25 Sichao25 marked this pull request as ready for review October 9, 2023 13:57
@Xiaojieqiu Xiaojieqiu merged commit 2e7497d into aristoteleo:master Oct 11, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants