Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(anta): provide test context when test inputs validation fails #579

Merged
merged 8 commits into from
Mar 12, 2024
Merged

fix(anta): provide test context when test inputs validation fails #579

merged 8 commits into from
Mar 12, 2024

Conversation

mtache
Copy link
Collaborator

@mtache mtache commented Mar 12, 2024 •
edited
Loading

  • fix(anta.catalog): provide test context when test inputs are not valid during catalog parsing
  • Move anta.tools.misc to anta.logger
  • fix: examples/tests.yaml
  • fix: add missing tests to examples/tests.yaml
  • fix: skip VerifyLANZ on cEOSLab and vEOS-lab
  • fix(anta): update unit tests for new logging
  • refactor(anta.tests): import pydantic.v1.utils.deep_update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have run pre-commit for code linting and typing (pre-commit run)
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes (tox -e testenv)

@mtache mtache changed the title fix(anta.catalog): provide test context when test inputs validation fails fix(anta): provide test context when test inputs validation fails Mar 12, 2024
carl-baillargeon
carl-baillargeon approved these changes Mar 12, 2024
View reviewed changes
Copy link
Contributor

@carl-baillargeon carl-baillargeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mtache mtache merged commit 5ac2af0 into aristanetworks:main Mar 12, 2024
19 checks passed
@mtache mtache deleted the invalid-inputs-logging branch March 12, 2024 15:21
@gmuloc gmuloc mentioned this pull request Apr 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carl-baillargeon carl-baillargeon carl-baillargeon approved these changes

Assignees

@mtache mtache

Labels
rn: fix(anta)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mtache @carl-baillargeon