feat(anta.tests): Added the testcase to verify hostname, location and contact #523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaheshGSLAB
commented
Jan 15, 2024
anta/tests/snmp.py
Outdated
|
|
||
| name = "VerifySnmpLocation" | ||
| description = "Verifies the SNMP location of a device." | ||
| categories = ["security"] |
There was a problem hiding this comment.
going to change the categories in next commit. missed to update. Same for VerifySnmpContact
There was a problem hiding this comment.
Yes please. There is an snmp category :)
Suggested change
| categories = ["security"] | |
| categories = ["snmp"] |
carl-baillargeon
approved these changes
Jan 29, 2024
anta/tests/snmp.py
Outdated
|
|
||
| name = "VerifySnmpLocation" | ||
| description = "Verifies the SNMP location of a device." | ||
| categories = ["security"] |
There was a problem hiding this comment.
Yes please. There is an snmp category :)
Suggested change
| categories = ["security"] | |
| categories = ["snmp"] |
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
MaheshGSLAB
force-pushed
the
issue-521
branch
from
5fc538f to
12d508b
Compare
MaheshGSLAB
force-pushed
the
issue-521
branch
from
12d508b to
68665ba
Compare
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
titom73
approved these changes
Feb 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added the testcase to verify hostname, location and contact details.
Fixes #521
Checklist:
pre-commit run)tox -e testenv)