-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
monitor/schema: support using atlas hcl file in monitor action #299
base: master
Are you sure you want to change the base?
Conversation
Atlas Lint ReportAnalyzed migrations2
Migrations automatically reviewed by Atlas |
Atlas Lint ReportAnalyzed migrations
Migrations automatically reviewed by Atlas |
2cd0dcd
to
5879762
Compare
|
Atlas detected changes to the desired schemaMigration Plan (View on Atlas Cloud)-- Create "t1" table
CREATE TABLE `t1` (
`c1` integer NOT NULL
);
-- Create "t2" table
CREATE TABLE `t2` (
`c1` integer NOT NULL
);
-- Create "t3" table
CREATE TABLE `t3` (
`c1` integer NOT NULL,
`c2` integer NOT NULL
); Atlas lint results
📝 Steps to edit this migration plan1. Run the following command to pull the generated plan to your local workstation: atlas schema plan pull --url "atlas://atlas-action/plans/pr-299-R1cGcSfo" > pr-299-R1cGcSfo.plan.hcl 2. Open 3. Push the updated plan to the registry using the following command: atlas schema plan push --pending --file pr-299-R1cGcSfo.plan.hcl 4. Re-trigger the gh run rerun 12696781149 |
9bc2498
to
3ff18ce
Compare
3ff18ce
to
e8de595
Compare
schema "main" {} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a5175b4
to
14ae5e8
Compare
You may need other inputs like extid, schemas and excludes from the config file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This requires a specific version of Atlas, right? How can we ensure .RedactedURL does exist?
I think in case the user decides to give us a custom config, all values should be provided in there, including exlcude pattersn and schema filter. |
how we can ensure that all values are supplied? |
yes only works with latest version of atlas |
14ae5e8
to
4aaba4e
Compare
Instead of Generate the ID here (in atlas-action), we can add the function in Atlas-CLI to return this ID. So, we can get it via the inspect command too. |
4aaba4e
to
6a36d0f
Compare
6a36d0f
to
306a612
Compare
No description provided.