Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fixed working-directory in tests #287

Merged
merged 1 commit into from
Dec 24, 2024
Merged

chore: fixed working-directory in tests #287

merged 1 commit into from
Dec 24, 2024

Conversation

giautm
Copy link
Member

@giautm giautm commented Dec 24, 2024

This PR ensure the atlas-action binary will be invoke in the temporary created by testscript, instead of the project root

Copy link

Atlas Lint Report

Analyzed migrations

StatusStepResultDiagnostics
Detect New Migration FilesFound 0 new migration files (from 0 total)
Replay Migration FilesLoaded 0 changes on dev database
Connect your project to Atlas Cloud to get more safety checks

Migrations automatically reviewed by Atlas

Copy link

Atlas Lint Report

Analyzed migrations2

StatusStepResultDiagnostics
Detect New Migration FilesFound 0 new migration files (from 0 total)
Replay Migration FilesLoaded 0 changes on dev database
Connect your project to Atlas Cloud to get more safety checks

Migrations automatically reviewed by Atlas

Copy link

github-actions bot commented Dec 24, 2024

Atlas detected changes to the desired schema

Migration Plan (View on Atlas Cloud)

-- Create "t1" table
CREATE TABLE `t1` (
  `c1` integer NOT NULL
);
-- Create "t2" table
CREATE TABLE `t2` (
  `c1` integer NOT NULL
);
-- Create "t3" table
CREATE TABLE `t3` (
  `c1` integer NOT NULL,
  `c2` integer NOT NULL
);

Atlas lint results

Status Step Result
Detect schema changes3 new statements detected
No issues found

📝 Steps to edit this migration plan

1. Run the following command to pull the generated plan to your local workstation:

atlas schema plan pull --url "atlas://atlas-action/plans/pr-286-R1cGcSfo" > pr-286-R1cGcSfo.plan.hcl

2. Open pr-286-R1cGcSfo in your editor and modify it as needed. Note that the result of the plan should align
the database with the desired state. Otherwise, Atlas will report a schema drift.

3. Push the updated plan to the registry using the following command:

atlas schema plan push --pending --file pr-286-R1cGcSfo.plan.hcl

4. Re-trigger the schema/plan action to update this comment:

gh run rerun 12482128411

Copy link

github-actions bot commented Dec 24, 2024

atlas migrate lint on atlasaction/testdata/migrations

Status Step Result
No migration files detected  
ERD and visual diff generated View Visualization
No issues found View Report
Read the full linting report on Atlas Cloud

@giautm giautm changed the title atlasaction: move github client to internal package chore: fixed working-directory in tests Dec 24, 2024
@giautm giautm force-pushed the g/testscript-wd branch 5 times, most recently from 1a774f0 to c3ca51e Compare December 24, 2024 12:10
@giautm giautm marked this pull request as ready for review December 24, 2024 12:20
@giautm giautm merged commit 3bbfc13 into master Dec 24, 2024
20 checks passed
@giautm giautm deleted the g/testscript-wd branch December 24, 2024 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants