atlasaction: allow the SCM client control the comment format #279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Atlas Lint ReportAnalyzed migrations
Migrations automatically reviewed by Atlas |
||||||||||||||||
|
|
||||||||||||||||
Atlas Lint ReportAnalyzed migrations2
Migrations automatically reviewed by Atlas |
||||||||||||||||
Atlas detected changes to the desired schemaMigration Plan (View on Atlas Cloud)-- Create "t1" table
CREATE TABLE `t1` (
`c1` integer NOT NULL
);
-- Create "t2" table
CREATE TABLE `t2` (
`c1` integer NOT NULL
);
-- Create "t3" table
CREATE TABLE `t3` (
`c1` integer NOT NULL,
`c2` integer NOT NULL
);Atlas lint results
📝 Steps to edit this migration plan1. Run the following command to pull the generated plan to your local workstation: atlas schema plan pull --url "atlas://atlas-action/plans/pr-272-R1cGcSfo" > pr-272-R1cGcSfo.plan.hcl2. Open 3. Push the updated plan to the registry using the following command: atlas schema plan push --pending --file pr-272-R1cGcSfo.plan.hcl |
giautm
commented
Dec 17, 2024
| @@ -24,7 +24,7 @@ the database with the desired state. Otherwise, Atlas will report a schema drift | |||
|
|
|||
| 3\. Push the updated plan to the registry using the following command: | |||
| ```bash | |||
| atlas schema plan push --pending --env {{ .EnvName }} --file {{ .Plan.File.Name }}.plan.hcl | |||
There was a problem hiding this comment.
env isn't require input. So, it empty if the user provides flags via inputs.
giautm
force-pushed
the
g/comment
branch
3 times, most recently
from
3b61557 to
c3fec19
Compare
giautm
requested review from
a8m,
masseelch,
datdao,
luantranminh and
ronenlu
ronenlu
reviewed
Dec 17, 2024
| default: | ||
| return nil, ErrNoSCM // Not implemented yet. | ||
| } | ||
| } | ||
|
|
||
| // addChecks runs annotations to the trigger event pull request for the given payload. | ||
| func (a *Actions) addChecks(lint *atlasexec.SummaryReport) error { |
There was a problem hiding this comment.
why you removing this functionality?
can you move it to github SCM?
There was a problem hiding this comment.
I moved it to the ghActions. Because Checks are GH's specific implement.
giautm
commented
Dec 17, 2024
| @@ -125,6 +130,42 @@ func (a *ghAction) WithFieldsMap(m map[string]string) Logger { | |||
| return &ghAction{a.Action.WithFieldsMap(m)} | |||
| } | |||
|
|
|||
| // addChecks runs annotations to the trigger event pull request for the given payload. | |||
| func (a *ghAction) addChecks(lint *atlasexec.SummaryReport) error { | |||
ronenlu
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.