-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
atlasaction: allow the action custom format of report #277
Conversation
Atlas Lint ReportAnalyzed migrations2
Migrations automatically reviewed by Atlas |
Atlas Lint ReportAnalyzed migrations
Migrations automatically reviewed by Atlas |
|
Atlas detected changes to the desired schemaMigration Plan (View on Atlas Cloud)-- Create "t1" table
CREATE TABLE `t1` (
`c1` integer NOT NULL
);
-- Create "t2" table
CREATE TABLE `t2` (
`c1` integer NOT NULL
);
-- Create "t3" table
CREATE TABLE `t3` (
`c1` integer NOT NULL,
`c2` integer NOT NULL
); Atlas lint results
📝 Steps to edit this migration plan1. Run the following command to pull the generated plan to your local workstation: atlas schema plan pull --url "atlas://atlas-action/plans/pr-272-R1cGcSfo" > pr-272-R1cGcSfo.plan.hcl 2. Open 3. Push the updated plan to the registry using the following command: atlas schema plan push --pending --env test --file pr-272-R1cGcSfo.plan.hcl 4. Re-trigger the gh run rerun 12332129218 |
MigrateApply(context.Context, *atlasexec.MigrateApply) | ||
MigrateLint(context.Context, *atlasexec.SummaryReport) | ||
SchemaPlan(context.Context, *atlasexec.SchemaPlan) | ||
SchemaApply(context.Context, *atlasexec.SchemaApply) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
May be just one method?
MigrateApply(context.Context, *atlasexec.MigrateApply) | |
MigrateLint(context.Context, *atlasexec.SummaryReport) | |
SchemaPlan(context.Context, *atlasexec.SchemaPlan) | |
SchemaApply(context.Context, *atlasexec.SchemaApply) | |
Report(context.Context, any) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why? Do you prefer type-switch over separate functions? I don't, because this way the callee don't need to handle unexpected inputs.
No description provided.