Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

atlasaction: report actions result via the Reports-API on Bitbucket #272

Merged
merged 2 commits into from
Dec 19, 2024

Conversation

giautm
Copy link
Member

@giautm giautm commented Dec 11, 2024

No description provided.

Copy link

Atlas Lint Report

Analyzed migrations

StatusStepResultDiagnostics
Detect New Migration FilesFound 0 new migration files (from 0 total)
Replay Migration FilesLoaded 0 changes on dev database
Connect your project to Atlas Cloud to get more safety checks

Migrations automatically reviewed by Atlas

Copy link

Atlas Lint Report

Analyzed migrations2

StatusStepResultDiagnostics
Detect New Migration FilesFound 0 new migration files (from 0 total)
Replay Migration FilesLoaded 0 changes on dev database
Connect your project to Atlas Cloud to get more safety checks

Migrations automatically reviewed by Atlas

Copy link

github-actions bot commented Dec 11, 2024

atlas migrate lint on atlasaction/testdata/migrations_destructive

Status Step Result
1 new migration file detected 20230925192914.sql
ERD and visual diff generated View Visualization
Analyze 20230925192914.sql
1 reports were found in analysis
Destructive changes detected
Dropping table "t1" (DS102)
Read the full linting report on Atlas Cloud

Copy link

atlas migrate lint on migrations

Status Step Result
No migration files detected  
ERD and visual diff generated View Visualization
No issues found View Report
Read the full linting report on Atlas Cloud

Copy link

github-actions bot commented Dec 11, 2024

Atlas detected changes to the desired schema

Migration Plan (View on Atlas Cloud)

-- Create "t1" table
CREATE TABLE `t1` (
  `c1` integer NOT NULL
);
-- Create "t2" table
CREATE TABLE `t2` (
  `c1` integer NOT NULL
);
-- Create "t3" table
CREATE TABLE `t3` (
  `c1` integer NOT NULL,
  `c2` integer NOT NULL
);

Atlas lint results

Status Step Result
Detect schema changes3 new statements detected
No issues found

📝 Steps to edit this migration plan

1. Run the following command to pull the generated plan to your local workstation:

atlas schema plan pull --url "atlas://atlas-action/plans/pr-272-R1cGcSfo" > pr-272-R1cGcSfo.plan.hcl

2. Open pr-272-R1cGcSfo in your editor and modify it as needed. Note that the result of the plan should align
the database with the desired state. Otherwise, Atlas will report a schema drift.

3. Push the updated plan to the registry using the following command:

atlas schema plan push --pending --file pr-272-R1cGcSfo.plan.hcl

4. Re-trigger the schema/plan action to update this comment:

gh run rerun 12412432170

@giautm giautm force-pushed the g/bitbucket branch 13 times, most recently from 6b80c20 to 27b3952 Compare December 15, 2024 21:31
@giautm giautm changed the title G/bitbucket atlasaction: report actions result via the Reports-API on Bitbucket Dec 16, 2024
@giautm giautm force-pushed the g/bitbucket branch 10 times, most recently from 0c65c12 to 3213b3a Compare December 18, 2024 06:39
@giautm giautm force-pushed the g/bitbucket branch 16 times, most recently from aaa24a6 to 15f44db Compare December 19, 2024 11:44
@giautm giautm force-pushed the g/bitbucket branch 2 times, most recently from 36e2dc0 to 755b9ea Compare December 19, 2024 11:59
@giautm giautm marked this pull request as ready for review December 19, 2024 12:03
ReportType: bitbucket.ReportTypeSecurity,
Title: "Atlas Lint",
Link: r.URL,
LogoURL: "https://ariga.io/assets/favicon.ico",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need better LogoURL

@giautm giautm requested review from a8m, masseelch, datdao, luantranminh and a team December 19, 2024 12:10
@giautm giautm merged commit 088144f into master Dec 19, 2024
20 checks passed
@giautm giautm deleted the g/bitbucket branch December 19, 2024 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants