Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test pr #121

Closed
wants to merge 12 commits into from
Closed

test pr #121

wants to merge 12 commits into from

Conversation

ronenlu
Copy link
Member

@ronenlu ronenlu commented Feb 18, 2024

  • atlasaction: add check runs comment in migrate lint action

  • update tests

Copy link

Atlas Lint Report

Analyzed migrations

StatusStepResultDiagnostics
Detect New Migration FilesFound 0 new migration files (from 0 total)
Replay Migration FilesLoaded 0 changes on dev database
Connect your project to Atlas Cloud to get more safety checks

Migrations automatically reviewed by Atlas

Copy link

Atlas Lint Report

Analyzed migrations2

StatusStepResultDiagnostics
Detect New Migration FilesFound 0 new migration files (from 0 total)
Replay Migration FilesLoaded 0 changes on dev database
Connect your project to Atlas Cloud to get more safety checks

Migrations automatically reviewed by Atlas

Copy link

github-actions bot commented Feb 18, 2024

atlas migrate lint on atlasaction/testdata/migrations

Status Step Link
1 new migration file detected  
ERD and Visual Diff generated View Visualization
No issues found. Full Report

Migrations automatically reviewed with Atlas

Copy link

github-actions bot commented Feb 18, 2024

atlas migrate lint on atlasaction/testdata/migrations_destructive

Status Step Link
1 new migration file detected  
ERD and Visual Diff generated View Visualization
1 error found Full Report

Migrations automatically reviewed with Atlas

@ronenlu ronenlu changed the title atlasaction: add check runs comment in migrate lint action (#118) test pr Feb 18, 2024
@ronenlu ronenlu force-pushed the test_branch branch 11 times, most recently from 26f2eff to 45af817 Compare February 18, 2024 14:50
@@ -1 +1,2 @@
-- drop table t1;
drop table t1;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
drop table t1;
-- atlas:txtar
-- checks/destructive.sql --
-- atlas:assert DS102
SELECT NOT EXISTS (SELECT 1 FROM `t1`) AS `is_empty`;
-- migration.sql --
drop table t1;

@@ -1 +1,2 @@
-- drop table t1;
drop table t1;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
drop table t1;
-- atlas:txtar
-- checks/destructive.sql --
-- atlas:assert DS102
SELECT NOT EXISTS (SELECT 1 FROM `t1`) AS `is_empty`;
-- migration.sql --
drop table t1;

@ronenlu ronenlu closed this Feb 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant